fix(@schematics/angular): add missing property "buildTarget" to interface "ServeBuilderOptions"#26694
Merged
dgp1130 merged 1 commit intoangular:mainfrom Dec 21, 2023
Merged
Conversation
…face "ServeBuilderOptions"
clydin
approved these changes
Dec 21, 2023
clydin
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The interface
ServeBuilderOptionsfrom@schematics/angular/utility/workspace-modelis missing the propertybuildTargetIssue Number: #26693
What is the new behavior?
The interface
ServeBuilderOptionsfrom@schematics/angular/utility/workspace-modelnow has the the propertybuildTarget. It's optional to avoid a breaking change, until the next major.Note: I've left the obsolete
browserTargetrequired property to avoid a breaking change. IMHO it's should be removed in the next major. But I marked thebrowserTargetproperty as@deprecated.Does this PR introduce a breaking change?
Other information